[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/Kconfig: move MAX_REBOOT_CNT option

[Marcello Sylvester Bauer (Code Review)]

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29979 )

Change subject: arch/x86/Kconfig: move MAX_REBOOT_CNT option
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 2:
> 
> (1 comment)
> 
> Currently, you can't set wrong values. That's a feature I'd like to
> have maintained.

i'll keep that in mind :)

> Everything below the currently defined defaults is
> wrong.

why are they wrong? I tested it with values below and it behaves like it should.

> In other words, this option was hidden on purpose. You can add another
> option for instance and take the minimum of both or something like
> that. But you mustn't lower it.

An other option would be to adapt the range in the Kconfig or fix the issue which cause this wrong behavior.

https://review.coreboot.org/#/c/29979/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29979/1//COMMIT_MSG@11 
PS1, Line 11: 
> It's not about complete reboots. If you'd set it to 2 you […]
sounds like an unintended behavior if that is true.
but i don't understand why it shouldn't be optional.
The default value of 3 sounds good IMHO, but in some use cases, your may want to change it.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c
Gerrit-Change-Number: 29979
Gerrit-PatchSet: 2
Gerrit-Owner: Marcello Sylvester Bauer <sylvblck at sylv.io>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck at sylv.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 23:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Comment-In-Reply-To: Marcello Sylvester Bauer <sylvblck at sylv.io>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/478327af/attachment.html>