[coreboot-gerrit] Change in ...coreboot[master]: src: Remove unused variables

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )

Change subject: src: Remove unused variables
......................................................................


Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/29917/13/src/soc/intel/fsp_broadwell_de/romstage/romstage.c 
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:

https://review.coreboot.org/#/c/29917/13/src/soc/intel/fsp_broadwell_de/romstage/romstage.c@a118 
PS13, Line 118: 
> breaks cbmem
Is this because "cbmem_was_initted" is used somewhere else, or because the call to "cbmem_recovery(0)" does some important stuff?


https://review.coreboot.org/#/c/29917/13/src/soc/intel/quark/i2c.c 
File src/soc/intel/quark/i2c.c:

https://review.coreboot.org/#/c/29917/13/src/soc/intel/quark/i2c.c@a132 
PS13, Line 132: 
> that breaks the fifo cleaning code
How does it break? Is there anything that could be done to remove the variable?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 13
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 01 Dec 2018 16:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/76d8771e/attachment.html>