[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Make the finalise handler common

Tristan Corrick (Code Review) gerrit at coreboot.org
Sat Dec 1 15:52:38 CET 2018


Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29975

to look at the new patch set (#2).

Change subject: sb/intel/lynxpoint: Make the finalise handler common
......................................................................

sb/intel/lynxpoint: Make the finalise handler common

The ASRock H81M-HDS doesn't implement a finalise handler. To fix
this, and reduce code duplication in the process, make a common
implementation. There should be no functional change to boards with
existing finalise handlers, since the code is identical among them and
the new, common implementation.

Tested on an ASRock H81M-HDS. The finalise handler works.

Change-Id: I13b581a2219288019a4e0c9e618db3ac7c3c15ab
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/mainboard/google/beltino/smihandler.c
M src/mainboard/google/slippy/smihandler.c
M src/mainboard/intel/baskingridge/mainboard_smi.c
M src/southbridge/intel/lynxpoint/smihandler.c
4 files changed, 15 insertions(+), 60 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/29975/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13b581a2219288019a4e0c9e618db3ac7c3c15ab
Gerrit-Change-Number: 29975
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/f5dcac56/attachment.html>


More information about the coreboot-gerrit mailing list