[coreboot-gerrit] Change in ...coreboot[master]: util/inteltool: Add support for Sunrise Point LP

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sat Dec 1 15:05:31 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28623 )

Change subject: util/inteltool: Add support for Sunrise Point LP
......................................................................


Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/28623/13/util/inteltool/gpio_groups.c 
File util/inteltool/gpio_groups.c:

https://review.coreboot.org/#/c/28623/13/util/inteltool/gpio_groups.c@55 
PS13, Line 55: 	"GPP_A12",	"BM_BUSY#",		"ISH_GP6",	"SX_EXIT_HOLDOFF#",
line over 80 characters


https://review.coreboot.org/#/c/28623/13/util/inteltool/gpio_groups.c@89 
PS13, Line 89: 	"GPP_A12",	"BM_BUSY#",		"ISH_GP6",	"SX_EXIT_HOLDOFF#",
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16237ffc9a225b46271f2a51d77a7f28dfc36138
Gerrit-Change-Number: 28623
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Sat, 01 Dec 2018 14:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/ca5141fa/attachment.html>


More information about the coreboot-gerrit mailing list