[coreboot-gerrit] Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@41
PS7, Line 41: 
> Yes, I edited the device id and it works now, so I guess we can remove it from the list of "known pr […]
We could patch the Option ROM with the "correct" PCI ID. Where correct is the filename in CBFS / the PCI ID of the card. Intel has the same problem, there's one Option ROM for multiple GPUs with different PCI IDs...

As Option ROMs aren't signed, that should be easy to do.



-- 
To view, visit https://review.coreboot.org/28380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5
Gerrit-Change-Number: 28380
Gerrit-PatchSet: 9
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Anonymous Coward (1002090)
Gerrit-Comment-Date: Fri, 31 Aug 2018 07:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/c7ca8e3c/attachment.html>