[coreboot-gerrit] Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 )

Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.c
File src/mainboard/lenovo/t430s/romstage.c:

https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.c@72
PS2, Line 72: 	enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED;
why not using the hybrid graphics driver ? it looks like the code is the same. Just use:

has_thinker1 = 1
has_panel_hybrid_gpio = 0
has_backlight_gpio = 0

I'm not sure about detect_gpio.

If you want to make sure hybrid_graphics_mode isn't DISCRETE (which can't be set using nvramtool or nvramcui anyway) you could use set_option() here and then call early_hybrid_graphics.



-- 
To view, visit https://review.coreboot.org/28393
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7
Gerrit-Change-Number: 28393
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 07:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/7a9b1787/attachment.html>