[coreboot-gerrit] Change in coreboot[master]: riscv: separately define stack locations at different stages

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Aug 31 05:13:14 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28383 )

Change subject: riscv: separately define stack locations at different stages
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayout.h
File src/arch/riscv/include/arch/memlayout.h:

https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayout.h@24
PS3, Line 24: 	#define CAR_STACK(addr, size) \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayout.h@32
PS3, Line 32: 	#define MEM_STACK(addr, size) \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/28383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a0c1928052cabf61ba5c25b440363b75726782
Gerrit-Change-Number: 28383
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 03:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/4bcb3521/attachment.html>


More information about the coreboot-gerrit mailing list