[coreboot-gerrit] Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@41
PS7, Line 41: - VGA ROM for Nvidia GPU is not loaded from BIOS (i.e. coreboot). Need
> Should work with pciXXXX,YYYY.rom in CBFS. […]
I think I know why it doesn't work. PCI ID of my dGPU is 10de:0ffc, which can be checked with `lspci -nn`. But the ROM I extracted from vendor UEFI dump is for 10de:0ffb, which can  be checked with `romheaders` and there's also "ID mismatch: vendor ID 10de, device ID 0ffb" error line in cbmem. I'll try to edit the device ID in the ROM image.



-- 
To view, visit https://review.coreboot.org/28380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5
Gerrit-Change-Number: 28380
Gerrit-PatchSet: 7
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 19:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/d05f6052/attachment.html>