[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Fix comment errors for SMBUS
Martin Roth (Code Review)
gerrit at coreboot.org
Thu Aug 30 16:48:48 CEST 2018
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28366 )
Change subject: soc/intel/cannonlake: Fix comment errors for SMBUS
......................................................................
soc/intel/cannonlake: Fix comment errors for SMBUS
On CannonLake PCH, SMBUS stays at Bus 0 Device 31 and Function 4,
previous comment in southbridge.asl mention it as Function 3 that was a
mistake.
BUG=N/A
TEST=N/A
Change-Id: I29786457379809b6fcb592e1136ff612539e24dc
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
Reviewed-on: https://review.coreboot.org/28366
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/cannonlake/acpi/southbridge.asl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi/southbridge.asl b/src/soc/intel/cannonlake/acpi/southbridge.asl
index 4a62485..e4f29b6 100644
--- a/src/soc/intel/cannonlake/acpi/southbridge.asl
+++ b/src/soc/intel/cannonlake/acpi/southbridge.asl
@@ -37,7 +37,7 @@
/* Serial IO */
#include "serialio.asl"
-/* SMBus 0:1f.3 */
+/* SMBus 0:1f.4 */
#include "smbus.asl"
/* USB XHCI 0:14.0 */
--
To view, visit https://review.coreboot.org/28366
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I29786457379809b6fcb592e1136ff612539e24dc
Gerrit-Change-Number: 28366
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/60ff0552/attachment.html>
More information about the coreboot-gerrit
mailing list