[coreboot-gerrit] Change in coreboot[master]: riscv: Add DEFINE_MPRV_READ_MXR to read execution-only page
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Aug 30 15:34:39 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28394 )
Change subject: riscv: Add DEFINE_MPRV_READ_MXR to read execution-only page
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/28394/2/src/arch/riscv/include/vm.h
File src/arch/riscv/include/vm.h:
https://review.coreboot.org/#/c/28394/2/src/arch/riscv/include/vm.h@57
PS2, Line 57: DEFINE_MPRV_READ_FLAGS(name, type, insn, MSTATUS_MPRV)
please, no spaces at the start of a line
https://review.coreboot.org/#/c/28394/2/src/arch/riscv/include/vm.h@60
PS2, Line 60: DEFINE_MPRV_READ_FLAGS(name, type, insn, MSTATUS_MPRV | MSTATUS_MXR)
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/28394
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19519782fe791982a8fbd48ef33b5a92a3c48bfc
Gerrit-Change-Number: 28394
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 13:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/0436aeec/attachment.html>
More information about the coreboot-gerrit
mailing list