[coreboot-gerrit] Change in coreboot[master]: google/grunt: Update Audio/H1/TP i2c timings

Chris Zhou (Code Review) gerrit at coreboot.org
Thu Aug 30 10:46:52 CEST 2018


Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/28397


Change subject: google/grunt: Update Audio/H1/TP i2c timings
......................................................................

google/grunt: Update Audio/H1/TP i2c timings

After adjustment on Liara Proto
Audio: 399.2 KHz
H1: 398.3 KHz
TP: 399.0 KHz

BUG=b:113319200
BRANCH=master
TEST=emerge-grunt coreboot chromeos-bootimage
     measure by scope

Change-Id: Ibba8c823ed8451a804cf731d49e7568a94ac7c6b
Signed-off-by: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
---
M src/mainboard/google/kahlee/variants/liara/devicetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/28397/1

diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
index b330ec5..cf6dd5f 100644
--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
@@ -24,7 +24,7 @@
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 95,
+		.rise_time_ns = 85,
 		.fall_time_ns = 3,
 	}"
 
@@ -32,15 +32,15 @@
 	register "i2c[1]" = "{
 		.early_init = 1,
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 84,
+		.rise_time_ns = 45,
 		.fall_time_ns = 4,
 	}"
 
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 117,
-		.fall_time_ns = 113,
+		.rise_time_ns = 48,
+		.fall_time_ns = 37,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz

-- 
To view, visit https://review.coreboot.org/28397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibba8c823ed8451a804cf731d49e7568a94ac7c6b
Gerrit-Change-Number: 28397
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/f5ed1335/attachment.html>


More information about the coreboot-gerrit mailing list