[coreboot-gerrit] Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@29
PS7, Line 29: - nouveau driver unloading (`rmmod` or `modprobe -r`) does not work well: it
Can you test if it does work without the optimus patch? I could imagine it's related to missing ACPI _BCM, _BCL, _BQC.
Have a look at  drivers_intel_gma_displays_ssdt_generate() for Intel GMA.


https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@41
PS7, Line 41: - VGA ROM for Nvidia GPU is not loaded from BIOS (i.e. coreboot). Need
Should work with pciXXXX,YYYY.rom in CBFS.
You can use acpi_dump to read it in chunks from generated _ROM.



-- 
To view, visit https://review.coreboot.org/28380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5
Gerrit-Change-Number: 28380
Gerrit-PatchSet: 7
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 06:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/d8bdb4d3/attachment.html>