[coreboot-gerrit] Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 )

Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage.c
File src/mainboard/lenovo/t430s/romstage.c:

https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage.c@76
PS1, Line 76: power_en
That will not power the dGPU if mode == dual graphics. PMH7 registers aren't cleared on reboot, only on battery and ext power failure. The hybrid graphics driver does it right.
Also not hiding PEG10 will draw +1Watt even with disabled dGPU.



-- 
To view, visit https://review.coreboot.org/28393
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7
Gerrit-Change-Number: 28393
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 05:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/a77b95d2/attachment.html>