[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Enable EC firmware update screen

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28374 )

Change subject: mainboard/google/kahlee: Enable EC firmware update screen
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:

https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig@101
PS1, Line 101:  if VBOOT_EC_SOFTWARE_SYNC
> nit: VBOOT_EC_SLOW_UPDATE already has a 'depends on VBOOT_EC_SOFTWARE_SYNC', this if clause is prett […]
Unfortunately, select statements override "depends on", so the 'if' is needed.

>From the Kconfig doc:
https://doc.coreboot.org/getting_started/kconfig.html

 Select statement usage
 The ‘select’ keyword forces the value of a symbol with a
 bool type to ‘y’. It overrides any dependencies of the
 symbol, so using it carelessly can lead to unpredictable
 results.



-- 
To view, visit https://review.coreboot.org/28374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e
Gerrit-Change-Number: 28374
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 29 Aug 2018 15:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180829/b94372d1/attachment.html>