[coreboot-gerrit] Change in coreboot[master]: mb/intel/dg43gt: Add documentation

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28258 )

Change subject: mb/intel/dg43gt: Add documentation
......................................................................


Patch Set 2:

(8 comments)

https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md
File Documentation/mainboard/intel/dg43gt.md:

https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@17
PS2, Line 17:  NO!
Any reason for this to be so intense? In any case, please harmonize the "yes" and "no" in the table (Yes/yes).


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@32
PS2, Line 32: to written
to *be* written


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@34
PS2, Line 34: --noverify
Is there any reason for this? If it is not necessary, I would omit it.


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@45
PS2, Line 45: reprogram 
> maybe "reprogram it"?
With the sentence as-is, I understand you can both reprogram and resolder the chip using a soldering iron.

IMHO, I would say: "Having removed the flash chip, you can reprogram it externally then resolder it using a soldering iron.".


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@51
PS2, Line 51: this
*T*his


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@53
PS2, Line 53: 3V
3.3V, maybe?


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@88
PS2, Line 88: Windond
Win*b*ond

Should the model be in uppercase? (W83627DHG)


https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt.md@90
PS2, Line 90: optionnaly
optionally



-- 
To view, visit https://review.coreboot.org/28258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e9dc67e66f719d440679b11332e2c8a764024f4
Gerrit-Change-Number: 28258
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Tue, 28 Aug 2018 14:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180828/15589232/attachment.html>