[coreboot-gerrit] Change in coreboot[master]: google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28353 )

Change subject: google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:

https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@54
PS1, Line 54: 	write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_EMMC_SETTING);
line over 80 characters


https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@56
PS1, Line 56: 	write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data | BH720_PCR_EMMC_SETTING_1_8V);
line over 80 characters


https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@57
PS1, Line 57: 	write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_EMMC_SETTING);
line over 80 characters


https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@60
PS1, Line 60: 	write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_CSR);
line over 80 characters


https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@62
PS1, Line 62: 	write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data & ~BH720_PCR_CSR_EMMC_MODE_SEL);
line over 80 characters


https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@63
PS1, Line 63: 	write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_CSR);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic080682e67323577c7f0ba4ed08f8adafca620cc
Gerrit-Change-Number: 28353
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 27 Aug 2018 04:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180827/36c1b464/attachment.html>