[coreboot-gerrit] Change in coreboot[master]: util: Add script to download FSP headers

Krzysztof M Sywula (Code Review) gerrit at coreboot.org
Sat Aug 25 01:34:33 CEST 2018


Krzysztof M Sywula has posted comments on this change. ( https://review.coreboot.org/28339 )

Change subject: util: Add script to download FSP headers
......................................................................


Patch Set 1:

Patrick, please review first revision of the script. I saw your comment asking for such utility.

Take a note that currently script doesn't support some families:
1. coreboot.org denverton_ns doesn't match github DenvertonNSFspBinPkg
2. coreboot.org skykabylake doesn't match github KabylakeFspBinPkg
3. coreboot.org glk doesn't exist on github
4. coreboot.org quark doesn't exist on github

(1) and (2) I would recommend renaming to denvertonns and kabylake accordingly as currently they don't follow naming convention.


-- 
To view, visit https://review.coreboot.org/28339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cda87a4cbfa7ce102b10b555f83cdf163c80e5f
Gerrit-Change-Number: 28339
Gerrit-PatchSet: 1
Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 23:34:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/c591a7f1/attachment.html>


More information about the coreboot-gerrit mailing list