[coreboot-gerrit] Change in coreboot[master]: soc/cavium: Add dynamic dtb support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28336 )

Change subject: soc/cavium: Add dynamic dtb support
......................................................................


Patch Set 2:

(4 comments)

also set the default devicetree in payloads linux and linuxboot to $(obj)/fit.dtb if FIT_DEVICETREE_NAME != "" ?

https://review.coreboot.org/#/c/28336/2/Makefile.inc
File Makefile.inc:

https://review.coreboot.org/#/c/28336/2/Makefile.inc@574
PS2, Line 574: FIT_DEVICETREE_FILE := $(src)/mainboard/$(MAINBOARDDIR)/$(FIT_DEVICETREE_NAME)
$(src)/mainboard/$(MAINBOARDDIR)/$(VARIANT_DIR)/$(FIT_DEVICETREE_NAME)


https://review.coreboot.org/#/c/28336/2/Makefile.inc@582
PS2, Line 582: 	dtc -I dts -O dtb -o $@ -i $(src)/mainboard/$(MAINBOARDDIR) -i $(src)/mainboard/$(VARIANT_DIR) $<
$(src)/mainboard/$(MAINBOARDDIR)/$(VARIANT_DIR)/


https://review.coreboot.org/#/c/28336/2/Makefile.inc@584
PS2, Line 584: cbfs-files-y += $(FIT_DEVICETREE_NAME)
has nothing to do with FIT. Should be placed in soc/cavium/cn81xx and marked deprecated


https://review.coreboot.org/#/c/28336/2/src/mainboard/Kconfig
File src/mainboard/Kconfig:

https://review.coreboot.org/#/c/28336/2/src/mainboard/Kconfig@186
PS2, Line 186: 	default ""
Overwrite the default in src/mainboard/cavium/cn81xx_sff_evb



-- 
To view, visit https://review.coreboot.org/28336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie470092e424b86e04141b8e2bd2b080a5aadcf58
Gerrit-Change-Number: 28336
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 15:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/e24629a4/attachment.html>