[coreboot-gerrit] Change in coreboot[master]: eve: Specify an unique ID for PS2 devices

Lucas Chen (Code Review) gerrit at coreboot.org
Fri Aug 24 13:07:57 CEST 2018


Hello Matt Delco,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28334

to review the following change.


Change subject: eve: Specify an unique ID for PS2 devices
......................................................................

eve: Specify an unique ID for PS2 devices

Windows certification tests will fail if the PS2 devices
are using Plug and Play ID (PNP0303).
For all Chromebooks we should use GOOG000A.

BRANCH=eve
BUG=b:110066056
TEST=AltOS certification test verify.

Change-Id: I479471fdb3102e3b492612a4e6ad07612273083a
Signed-off-by: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1098874
Reviewed-by: Matt Delco <delco at chromium.org>
Reviewed-by: Hung-Te Lin <hungte at chromium.org>
Commit-Queue: Hung-Te Lin <hungte at chromium.org>
Trybot-Ready: Hung-Te Lin <hungte at chromium.org>
---
M src/ec/google/chromeec/acpi/superio.asl
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/28334/1

diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl
index 8faabee..6c9cb2c 100644
--- a/src/ec/google/chromeec/acpi/superio.asl
+++ b/src/ec/google/chromeec/acpi/superio.asl
@@ -137,8 +137,8 @@
 	{
 		Name (_UID, 0)
 		Name (_ADR, 0)
-		Name (_HID, EISAID("PNP0303"))
-		Name (_CID, EISAID("PNP030B"))
+		Name (_HID, "GOOG000A")
+		Name (_CID, Package() { EISAID("PNP0303"), EISAID("PNP030B") } )
 
 		Method (_STA, 0, NotSerialized) {
 			Return (0x0F)

-- 
To view, visit https://review.coreboot.org/28334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I479471fdb3102e3b492612a4e6ad07612273083a
Gerrit-Change-Number: 28334
Gerrit-PatchSet: 1
Gerrit-Owner: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/565ae04e/attachment.html>


More information about the coreboot-gerrit mailing list