[coreboot-gerrit] Change in coreboot[master]: util/pmh7tool: Add tool to dump PMH7 registers

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Aug 24 12:34:18 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27776 )

Change subject: util/pmh7tool: Add tool to dump PMH7 registers
......................................................................


Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/27776/9/util/pmh7tool/pmh7tool.c
File util/pmh7tool/pmh7tool.c:

https://review.coreboot.org/#/c/27776/9/util/pmh7tool/pmh7tool.c@151
PS9, Line 151: 		fprintf(stderr, "Error: <addr> cannot be greater than 9 bits long.\n");
line over 80 characters


https://review.coreboot.org/#/c/27776/9/util/pmh7tool/pmh7tool.c@157
PS9, Line 157: 			fprintf(stderr, "Error: <bit> cannot be greater than 8.\n");
line over 80 characters


https://review.coreboot.org/#/c/27776/9/util/pmh7tool/pmh7tool.c@162
PS9, Line 162: 			fprintf(stderr, "Error: <data> cannot be greater than 9 bits long.\n");
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ccb5a9a861fe44efec794aafe1805062543d53
Gerrit-Change-Number: 27776
Gerrit-PatchSet: 9
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 10:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/551120d7/attachment.html>


More information about the coreboot-gerrit mailing list