[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba

[Pan Sheng-Liang (Code Review)]

Hello Sheng-Liang Pan,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28332

to review the following change.


Change subject: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba
......................................................................

mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba

add device "WCOM Digitizer" and "Synaptics Touchpad" for bobba

BUG=none
BRANCH=master
TEST=emerge-octopus coreboot

Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db
Signed-off-by: Pan Sheng-Liang <sheng-liang.pan at quanta.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/28332/1

diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
index 6726b41..acb1d50 100644
--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
@@ -1,6 +1,17 @@
 chip soc/intel/apollolake
 
 	device domain 0 on
+		device pci 16.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""WCOM50C1""
+				register "generic.desc" = ""WCOM Digitizer""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_139_IRQ)"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x1"
+				device i2c 0x9 on end
+			end
+		end	# - I2C 0
 		device pci 17.1 on
 			chip drivers/i2c/da7219
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_137_IRQ)"
@@ -29,6 +40,15 @@
 				register "probed" = "1"
 				device i2c 15 on end
 			end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_135_IRQ)"
+				register "generic.wake" = "GPE0_DW2_02"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 0x2c on end
+			end
 		end	# - I2C 6
 		device pci 17.3 on
 			chip drivers/i2c/generic

-- 
To view, visit https://review.coreboot.org/28332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db
Gerrit-Change-Number: 28332
Gerrit-PatchSet: 1
Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw at gmail.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan at quanta.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/abe34f2e/attachment.html>