[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Add missing standby settings.

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28328 )

Change subject: mb/google/octopus: Add missing standby settings.
......................................................................


Patch Set 1:

(9 comments)

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@120
PS1, Line 120: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@121
PS1, Line 121: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@247
PS1, Line 247: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bip/gpio.c@118
PS1, Line 118: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bip/gpio.c@119
PS1, Line 119: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bip/gpio.c@246
PS1, Line 246: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bobba/gpio.c
File src/mainboard/google/octopus/variants/bobba/gpio.c:

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/bobba/gpio.c@34
PS1, Line 34: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/fleex/gpio.c
File src/mainboard/google/octopus/variants/fleex/gpio.c:

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/fleex/gpio.c@49
PS1, Line 49: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
line over 80 characters


https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/phaser/gpio.c
File src/mainboard/google/octopus/variants/phaser/gpio.c:

https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variants/phaser/gpio.c@36
PS1, Line 36: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a76cd2a1481c828fc092aaf7e870a411624879c
Gerrit-Change-Number: 28328
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 05:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/53d009d7/attachment.html>