[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/pi/00670F00/Lib/AmdLib.c: Remove IdsErrorStop

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28295


Change subject: vendorcode/amd/pi/00670F00/Lib/AmdLib.c: Remove IdsErrorStop
......................................................................

vendorcode/amd/pi/00670F00/Lib/AmdLib.c: Remove IdsErrorStop

Function IdsErrorStop() is only used within AmdLib.c function
LibAmdMsrRead(), which in turn is only used once within PspBaseLib.c and
three times inside AmdLib.c, all with well defined MSR addresses.
IdsErrorStop() is used as a trap if MSR address is 0 or 0xFFFFFFFF, which
clearly it's not. Therefor it can be safely removed from AmdLib.c.

BUG=b:112885948
TEST=Build grunt

Change-Id: I47ffcbd4fbae28b6d711a340f0ac3f3b007e8e4f
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/vendorcode/amd/pi/00670F00/Lib/amdlib.c
1 file changed, 0 insertions(+), 27 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/28295/1

diff --git a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c
index b03beee..8a4113f 100644
--- a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c
+++ b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c
@@ -266,9 +266,6 @@
   IN OUT   AMD_CONFIG_PARAMS *ConfigPtr
   )
 {
-  if ((MsrAddress == 0xFFFFFFFF) || (MsrAddress == 0x00000000)) {
-	  IdsErrorStop(MsrAddress);
-  }
   *Value = __readmsr (MsrAddress);
 }
 
@@ -574,27 +571,3 @@
   }
   return MmioIsEnabled;
 }
-
-BOOLEAN
-IdsErrorStop (
-  IN      UINT32 FileCode
-  )
-{
-	struct POST {
-		UINT16 deadlo;
-		UINT32 messagelo;
-		UINT16 deadhi;
-		UINT32 messagehi;
-	} post = {0xDEAD, FileCode, 0xDEAD, FileCode};
-	UINT16 offset = 0;
-	UINT16 j;
-
-	while(1) {
-		offset %= sizeof(struct POST) / 2;
-		WriteIo16(80, *((UINT16 *)&post)+offset);
-		++offset;
-		for (j=0; j<250; ++j) {
-			ReadIo8(80);
-		}
-	}
-}

-- 
To view, visit https://review.coreboot.org/28295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47ffcbd4fbae28b6d711a340f0ac3f3b007e8e4f
Gerrit-Change-Number: 28295
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180823/5df16d1f/attachment.html>