[coreboot-gerrit] Change in coreboot[master]: fsp/fsp2_0/coffeelake: Update CFL FSP headers

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28286 )

Change subject: fsp/fsp2_0/coffeelake: Update CFL FSP headers
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2: Code-Review+2
> > 
> > (1 comment)
> 
> I am not too sure all the other header file revision is synced with version on  coreboot.org, so didn't dare to include all the headers file yet. Add Nathaniel in to reviewer to get his opinion from fsp side. In the mean time, I can drop the script from this commit and have an follow up one to update all fsp headers together.

My concern wasn't so much about the other headers, just about making the script more general and put it in a more easily discovered location.

Although, keeping it all in sync would be nice, yes. Or, once/if redistribution is settled, just use them from the repo (that could be put in 3rdparty/fsp-blobs or whatever). But that's all stuff for a separate change.


-- 
To view, visit https://review.coreboot.org/28286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656da83e9042642576b785643e423ba47da8dd73
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 23 Aug 2018 16:23:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180823/bdf253b1/attachment.html>