[coreboot-gerrit] Change in coreboot[master]: smmstore: Add a key/val store facility in flash, mediated through SMM

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )

Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................


Patch Set 11:

(5 comments)

https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:

https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c@180
PS11, Line 180: 	if (rdev_writeat(&store, &key_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c@184
PS11, Line 184: 	if (rdev_writeat(&store, &value_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c@188
PS11, Line 188: 	if (rdev_writeat(&store, key, end, key_sz) != key_sz) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c@192
PS11, Line 192: 	if (rdev_writeat(&store, value, end, value_sz) != value_sz) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/11/src/drivers/smmstore/store.c@197
PS11, Line 197: 	if (rdev_writeat(&store, &nul, end, 1) != 1) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: Joel Kitching <kitching at google.com>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 23 Aug 2018 15:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180823/bb95dc62/attachment.html>