[coreboot-gerrit] Change in coreboot[master]: x86/acpi: Add ACPI table revision function

Marc Jones (Code Review) gerrit at coreboot.org
Thu Aug 23 06:03:05 CEST 2018


Hello Marshall Dawson, Duncan Laurie, build bot (Jenkins), Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28276

to look at the new patch set (#3).

Change subject: x86/acpi: Add ACPI table revision function
......................................................................

x86/acpi: Add ACPI table revision function

Use a single function to set ACPI table versions. This allows us
to keep revisions synced to the correct levels for coreboot. This
is a partial fix for the bug:

FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not
in sync with the FADT revision; MADT 1 expects FADT 3.0 but found 4.0
instead.

BUG=b:112476331
TEST-Run FWTS

Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/arch/x86/acpi.c
M src/arch/x86/include/arch/acpi.h
2 files changed, 80 insertions(+), 17 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28276/3
-- 
To view, visit https://review.coreboot.org/28276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b
Gerrit-Change-Number: 28276
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180823/52b7b11b/attachment.html>


More information about the coreboot-gerrit mailing list