[coreboot-gerrit] Change in coreboot[master]: x86/acpi: Update MADT table version

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/28256 )

Change subject: x86/acpi: Update MADT table version
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Is it worthwhile to do something to keep these in sync in the future?  Maybe a function that both tables call to get their values?  
> 
>  #define MADT 1
>  #define FADT 2
> 
>  int get_fadt_madt_version (int table)
>  {
>     if (table == MADT)
>       return 2; /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */
>     if (table == FADT)
>       return ACPI_FADT_REV_ACPI_3_0;
>     return -1;

I guess we should expand it to every table type revision.


-- 
To view, visit https://review.coreboot.org/28256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 22 Aug 2018 16:18:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180822/22327138/attachment.html>