[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Move board specific things to mc_apl1 variant

Mario Scheithauer (Code Review) gerrit at coreboot.org
Wed Aug 22 13:57:18 CEST 2018


Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/28269


Change subject: siemens/mc_apl1: Move board specific things to mc_apl1 variant
......................................................................

siemens/mc_apl1: Move board specific things to mc_apl1 variant

A FPGA is not necessarily available in further mc_apl1 variants. So we
move the loading of the driver and the notify function to the mc_apl1
variant.

Change-Id: I9f8438407f231df08e1ad04655bb6f747257e268
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/Kconfig
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/28269/1

diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig
index 44b81dc..d0a7610 100644
--- a/src/mainboard/siemens/mc_apl1/Kconfig
+++ b/src/mainboard/siemens/mc_apl1/Kconfig
@@ -5,9 +5,7 @@
 	select BOARD_ROMSIZE_KB_16384
 	select HAVE_ACPI_TABLES
 	select USE_SIEMENS_HWILIB
-	select DRIVER_SIEMENS_NC_FPGA
 	select APL_SKIP_SET_POWER_LIMITS
-	select NC_FPGA_NOTIFY_CB_READY
 
 source "src/mainboard/siemens/mc_apl1/variants/*/Kconfig"
 
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig
index ae72d9e..ac10904 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig
@@ -6,6 +6,8 @@
 	select DRIVER_INTEL_I210
 	select DRIVERS_I2C_RX6110SA
 	select DRIVERS_UART_8250IO
+	select DRIVER_SIEMENS_NC_FPGA
+	select NC_FPGA_NOTIFY_CB_READY
 
 config DEVICETREE
 	string

-- 
To view, visit https://review.coreboot.org/28269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f8438407f231df08e1ad04655bb6f747257e268
Gerrit-Change-Number: 28269
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180822/002dbeb0/attachment.html>


More information about the coreboot-gerrit mailing list