[coreboot-gerrit] Change in coreboot[master]: google/kukui: Setup GPIOs for ChromeOS.

Tristan Hsieh (Code Review) gerrit at coreboot.org
Tue Aug 21 10:34:58 CEST 2018


Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/28250 )

Change subject: google/kukui: Setup GPIOs for ChromeOS.
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/28250/3/src/mainboard/google/kukui/chromeos.c
File src/mainboard/google/kukui/chromeos.c:

https://review.coreboot.org/#/c/28250/3/src/mainboard/google/kukui/chromeos.c@30
PS3, Line 30: -1
Not really sure if there will be a lid in kukui. Make it always high.



-- 
To view, visit https://review.coreboot.org/28250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec2c70c189a059219954e0384aaf98995285728
Gerrit-Change-Number: 28250
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 21 Aug 2018 08:34:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180821/fca992ac/attachment.html>


More information about the coreboot-gerrit mailing list