[coreboot-gerrit] Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Aug 20 11:48:36 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28104 )

Change subject: lib/fit_payload: Add coreboot tables support for FDT.
......................................................................


Patch Set 9:

(2 comments)

https://review.coreboot.org/#/c/28104/9/src/lib/fit_payload.c
File src/lib/fit_payload.c:

https://review.coreboot.org/#/c/28104/9/src/lib/fit_payload.c@113
PS9, Line 113: 	static const char *firmware_path[] = {"firmware", NULL};
static const char * array should probably be static const char * const


https://review.coreboot.org/#/c/28104/9/src/lib/fit_payload.c@120
PS9, Line 120: 	static const char *coreboot_path[] = {"coreboot", NULL};
static const char * array should probably be static const char * const



-- 
To view, visit https://review.coreboot.org/28104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977
Gerrit-Change-Number: 28104
Gerrit-PatchSet: 9
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Mon, 20 Aug 2018 09:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180820/cbcfc8b3/attachment.html>


More information about the coreboot-gerrit mailing list