[coreboot-gerrit] Change in coreboot[master]: superio/ite/it8721f: Add SuperIO ACPI declarations

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/28226 )

Change subject: superio/ite/it8721f: Add SuperIO ACPI declarations
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/28226/1/src/superio/ite/it8721f/acpi/superio.asl
File src/superio/ite/it8721f/acpi/superio.asl:

https://review.coreboot.org/#/c/28226/1/src/superio/ite/it8721f/acpi/superio.asl@98
PS1, Line 98: IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02)
you could use fixed io instead of io here



-- 
To view, visit https://review.coreboot.org/28226
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I074d57fa5b140b6946ae81beb210fefac48a66eb
Gerrit-Change-Number: 28226
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 20 Aug 2018 06:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180820/8323b90b/attachment.html>