[coreboot-gerrit] Change in coreboot[master]: superio/ite/it8721f: Add resources

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Aug 20 01:07:22 CEST 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/28225


Change subject: superio/ite/it8721f: Add resources
......................................................................

superio/ite/it8721f: Add resources

There is no public datasheet available for this SuperIO so the resources are
guessed by looking at other ITE SuperIO's and the register dumps while running
vendor firmware.

The only board with this SuperIO in the tree is the asus m5a88-v. Most of the
devicetree entries would have been invalid here so one should not worry too much
about regressions.

Tested with Foxconn d41s.

Change-Id: I6715c68b3aa9aebf6e292975cbf64ce905b30e8b
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/superio/ite/it8721f/superio.c
1 file changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/28225/1

diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c
index 52a1456..cf3ca3f 100644
--- a/src/superio/ite/it8721f/superio.c
+++ b/src/superio/ite/it8721f/superio.c
@@ -54,12 +54,22 @@
 	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
 };
 
-/* TODO: FDC, PP, EC, KBCM, IR. */
+/* Guessed */
 static struct pnp_info pnp_dev_info[] = {
+	{ NULL, IT8721F_FDC,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0
+	  | PNP_MSC0 | PNP_MSC1, 0x0ff8, },
 	{ NULL, IT8721F_SP1,  PNP_IO0 | PNP_IRQ0, 0x07f8, },
 	{ NULL, IT8721F_SP2,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0 | PNP_DRQ1,
 		0x07f8, },
+	{ NULL, IT8721F_PP,   PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_DRQ0 | PNP_MSC0,
+	  0x0ff8, 0x0ff8, },
+	{ NULL, IT8721F_EC,   PNP_IO0 | PNP_IO1 | PNP_IRQ0
+	  | PNP_MSC0 | PNP_MSC1 | PNP_MSC2 | PNP_MSC3
+	  | PNP_MSC4 | PNP_MSC5 | PNP_MSC6,
+	  0x0ff8, 0x0ff8, },
 	{ NULL, IT8721F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07f8, 0x07f8, },
+	{ NULL, IT8721F_KBCM, PNP_IRQ0 | PNP_MSC0, },
+	{ NULL, IT8721F_IR, },
 };
 
 static void enable_dev(struct device *dev)

-- 
To view, visit https://review.coreboot.org/28225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6715c68b3aa9aebf6e292975cbf64ce905b30e8b
Gerrit-Change-Number: 28225
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180819/686b1b57/attachment-0001.html>


More information about the coreboot-gerrit mailing list