[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/pmh7: support 9bit address space

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/28196 )

Change subject: ec/lenovo/pmh7: support 9bit address space
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/28196/2/src/ec/lenovo/pmh7/pmh7.h
File src/ec/lenovo/pmh7/pmh7.h:

https://review.coreboot.org/#/c/28196/2/src/ec/lenovo/pmh7/pmh7.h@23
PS2, Line 23: #define EC_LENOVO_PMH7_ADDR_1 (EC_LENOVO_PMH7_BASE + 0x0d)
maybe use the suffixes _L and _H instead of _0 and _1; at least for me it would be clearer that those are the lower and higher byte of the address



-- 
To view, visit https://review.coreboot.org/28196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d7ce00950862adf928a88d70afbc33df8b87d9a
Gerrit-Change-Number: 28196
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 19 Aug 2018 01:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180819/cdce0776/attachment.html>