[coreboot-gerrit] Change in coreboot[master]: atlas: enable keyboard backlight support

Caveh Jalali (Code Review) gerrit at coreboot.org
Sat Aug 18 05:15:57 CEST 2018


Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28205

to review the following change.


Change subject: atlas: enable keyboard backlight support
......................................................................

atlas: enable keyboard backlight support

This adds support for controlling the keyboard backlight over ACPI.

BUG=b:112619894
BRANCH=none
TEST=verified keyboard backlight can be adjusted using keyboard
	shortcuts

Change-Id: I25713f341e8b5a4e50903ac109bfa717f20969d8
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/28205/1

diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
index 22bcef5..484510b 100644
--- a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
@@ -78,4 +78,7 @@
 #define SIO_EC_HOST_ENABLE	/* EC Host Interface Resources */
 #define SIO_EC_ENABLE_PS2K	/* Enable PS/2 Keyboard */
 
+/* Enable EC backed Keyboard Backlight in ACPI */
+#define EC_ENABLE_KEYBOARD_BACKLIGHT
+
 #endif /* __MAINBOARD_EC_H__ */

-- 
To view, visit https://review.coreboot.org/28205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25713f341e8b5a4e50903ac109bfa717f20969d8
Gerrit-Change-Number: 28205
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180818/e2ff3f1c/attachment.html>


More information about the coreboot-gerrit mailing list