[coreboot-gerrit] Change in coreboot[master]: security/tpm: Fix TPM 1.2 state machine issues

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/28085 )

Change subject: security/tpm: Fix TPM 1.2 state machine issues
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c
File src/drivers/tpm/tpm.c:

https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c@35
PS3, Line 35: 	if (result == TPM_E_MUST_REBOOT)
            : 		do_global_reset();
> This code isn't used for Chrome OS. But maybe we should somehow check for the reboot count

how come - how is TPM 1.2 initialized on Chrome OS devices?



-- 
To view, visit https://review.coreboot.org/28085
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ided110e0c1889b302e29acac6d8d2341f97eb10b
Gerrit-Change-Number: 28085
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 16:30:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/a083e9f9/attachment.html>