[coreboot-gerrit] Change in coreboot[master]: Nami: Disable powering off EC on cr50 update

Daisuke Nojiri (Code Review) gerrit at coreboot.org
Thu Aug 16 02:57:36 CEST 2018


Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/28113


Change subject: Nami: Disable powering off EC on cr50 update
......................................................................

Nami: Disable powering off EC on cr50 update

Nami doesn't support wakeup from hibernation by CR50. This causes the
device to remain turned off after CR50 update.

This patch disables turning off EC on cr50 update. CR50 resets the
whole system. So, EC reset is not required.

Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>

BUG=b:112604277
BRANCH=none
TEST=gsctool -a -u /media/removable/cr50.bin && reboot
Verify EC reboots. AP prints 'Waiting for CR50 reset to pick up update'
then reboots.

Change-Id: I06f5eb6100e8af6ffec45d4de2b40eff44f89709
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/28113/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index fc090df..1645451 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -169,6 +169,7 @@
 	select DRIVERS_SPI_ACPI
 	select EXCLUDE_NATIVE_SD_INTERFACE
 	select MAINBOARD_HAS_SPI_TPM_CR50
+	select DISABLE_POWER_OFF_EC_ON_CR50_UPDATE
 
 config VARIANT_SPECIFIC_OPTIONS_NAUTILUS
 	def_bool n

-- 
To view, visit https://review.coreboot.org/28113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06f5eb6100e8af6ffec45d4de2b40eff44f89709
Gerrit-Change-Number: 28113
Gerrit-PatchSet: 1
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/4a27ba69/attachment.html>


More information about the coreboot-gerrit mailing list