[coreboot-gerrit] Change in coreboot[master]: ec/google/chromec/acpi: switch tablet device from .h to Kconfig

Matt Delco (Code Review) gerrit at coreboot.org
Thu Aug 16 00:59:33 CEST 2018


Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28108


Change subject: ec/google/chromec/acpi: switch tablet device from .h to Kconfig
......................................................................

ec/google/chromec/acpi: switch tablet device from .h to Kconfig

The ACPI tablet mode device was previously enabled by setting a #define
in an ec.h file.  Prior changes have (if correct) set an analogous
setting in Kconfig. This change changes the compile-time check to be
based on Kconfig rather than ec.h.

Change-Id: Ie7d7301c2a11c3ae32b870b724018832200b49eb
Signed-off-by: Matt Delco <delco at chromium.org>
---
M src/ec/google/chromeec/acpi/ec.asl
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/28108/1

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 94917dd..90ff62f 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -374,7 +374,7 @@
 #ifdef EC_ENABLE_TABLET_EVENT
 		\_SB.DPTF.TPET()
 #endif
-#ifdef EC_ENABLE_TBMC_DEVICE
+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE)
 		Notify (TBMC, 0x80)
 #endif
 	}
@@ -547,7 +547,7 @@
 	#include "pd.asl"
 #endif
 
-#ifdef EC_ENABLE_TBMC_DEVICE
+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE)
 	#include "tbmc.asl"
 #endif
 }

-- 
To view, visit https://review.coreboot.org/28108
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7d7301c2a11c3ae32b870b724018832200b49eb
Gerrit-Change-Number: 28108
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180815/085f9ba4/attachment-0001.html>


More information about the coreboot-gerrit mailing list