[coreboot-gerrit] Change in coreboot[master]: cpu/intel/common: add function to init cppc_config

[Matt Delco (Code Review)]

Matt Delco has posted comments on this change. ( https://review.coreboot.org/28068 )

Change subject: cpu/intel/common: add function to init cppc_config
......................................................................


Patch Set 4:

> Why don't you put it into src/cpu/intel ? It looks like version 2 could be used on all Intel CPUs in tree.

So I made an attempt to move it under there and revised the change.  The best place I could spot was under common, and while I don't like sticking it in the only source file called common_init.c I also wasn't ready to break it out into a separate file yet either.  The cpu/ and soc/ subdirs appear to be operating and evolving separately (e.g., they each have different implementations to enable vmx).

I'm open to feedback on different ways to do this, though I'm also curious to see what the buildbot thinks of this attempt.


-- 
To view, visit https://review.coreboot.org/28068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib767df63d796bd1f21e36bcf575cf912e09090a1
Gerrit-Change-Number: 28068
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 19:20:55 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180815/33c8a807/attachment.html>