[coreboot-gerrit] Change in coreboot[master]: mb/google/atlas: Add DISPLAY_DCR_EN GPIO pin
Patrick Georgi (Code Review)
gerrit at coreboot.org
Wed Aug 15 11:37:13 CEST 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28070 )
Change subject: mb/google/atlas: Add DISPLAY_DCR_EN GPIO pin
......................................................................
mb/google/atlas: Add DISPLAY_DCR_EN GPIO pin
This defines new GPIO pin for controlling the display panel CABC
function. The default value is high (enabled).
BUG=b:112154569
Change-Id: I29083ab18e37f929a55b450b143463c67fe0abea
Signed-off-by: Caveh Jalali <caveh at chromium.org>
Reviewed-on: https://review.coreboot.org/28070
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/atlas/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
caveh jalali: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c
index 51dbf69..c0ef9ef 100644
--- a/src/mainboard/google/poppy/variants/atlas/gpio.c
+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c
@@ -215,8 +215,8 @@
PAD_CFG_NC(GPP_E4),
/* E5 : SATA_DEVSLP1 ==> NC */
PAD_CFG_NC(GPP_E5),
- /* E6 : SATA_DEVSLP2 ==> NC */
- PAD_CFG_NC(GPP_E6),
+ /* E6 : SATA_DEVSLP2 ==> DISPLAY_DCR_EN */
+ PAD_CFG_GPO(GPP_E6, 1, DEEP),
/* E7 : CPU_GP1 ==> TOUCHSCREEN_INT_L */
PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST),
/* E8 : SATALED# ==> NC */
--
To view, visit https://review.coreboot.org/28070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I29083ab18e37f929a55b450b143463c67fe0abea
Gerrit-Change-Number: 28070
Gerrit-PatchSet: 4
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180815/12388cc7/attachment.html>
More information about the coreboot-gerrit
mailing list