[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add bootblock_fch_init

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28059 )

Change subject: soc/amd/stoneyridge: Add bootblock_fch_init
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/28059/2/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/28059/2/src/soc/amd/stoneyridge/southbridge.c@648
PS2, Line 648: {}
Very nitty, but I think most of coreboot does functions' braces on their own lines, excepting inline and weak functions.  Given that this is here solely for the purpose of filling it, I'm not sure that I care much.



-- 
To view, visit https://review.coreboot.org/28059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dff30e589761fbad92cfc2709546dba169993d8
Gerrit-Change-Number: 28059
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Edward Hill <ecgh at chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 14 Aug 2018 00:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/c0bea150/attachment.html>