[coreboot-gerrit] Change in coreboot[master]: superio/winbond/w83627hf: Remove unused value
Patrick Georgi (Code Review)
gerrit at coreboot.org
Mon Aug 13 17:39:34 CEST 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28058 )
Change subject: superio/winbond/w83627hf: Remove unused value
......................................................................
superio/winbond/w83627hf: Remove unused value
Change-Id: I90d1997254f6766f4c61ff55449109adbdd783e3
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/28058
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/superio/winbond/w83627hf/superio.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Patrick Georgi: Looks good to me, approved
diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c
index 733dc35..21c3016 100644
--- a/src/superio/winbond/w83627hf/superio.c
+++ b/src/superio/winbond/w83627hf/superio.c
@@ -40,7 +40,7 @@
static void init_acpi(struct device *dev)
{
- u8 value = 0x20; /* FIXME: The 0x20 value here is never used? */
+ u8 value;
int power_on = 1;
get_option(&power_on, "power_on_after_fail");
--
To view, visit https://review.coreboot.org/28058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90d1997254f6766f4c61ff55449109adbdd783e3
Gerrit-Change-Number: 28058
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180813/857d014f/attachment.html>
More information about the coreboot-gerrit
mailing list