[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add failure safety configurations

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27714 )

Change subject: security/vboot: Add failure safety configurations
......................................................................


Patch Set 4:

(4 comments)

https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@53
PS1, Line 53: 	bool
> Can you outline your bigger plan with these MAINBOARD_... and USER_... […]
Easy peasy.

1) Users can decide for a Slot layout if not set by the board.
2) Slot layouts can be set by the board.
3) I will write an fmapgen tool for generating fmaps dynamically by kconfig input.


https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@54
PS1, Line 54: 
> nit: not sure I like calling this "safety", that seems a little far removed from what it actually co […]
Ack


https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@57
PS1, Line 57: 
> nit: I would avoid using the name "recovery" here since it means something specific and different in […]
Ack


https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@71
PS1, Line 71: config USER_VBOOT_SLOTS_A
> Technically the "firmware" might consist of IFD and ME or other blobs, too. […]
Ack



-- 
To view, visit https://review.coreboot.org/27714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I278fc060522b13048b00090b8e5261c14496f56e
Gerrit-Change-Number: 27714
Gerrit-PatchSet: 4
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Sat, 11 Aug 2018 04:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180811/e4ef87c7/attachment.html>