[coreboot-gerrit] Change in coreboot[master]: util/bincfg: don't use sym_table shared variable

Paul Kocialkowski (Code Review) gerrit at coreboot.org
Fri Aug 10 11:24:51 CEST 2018


Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/27810 )

Change subject: util/bincfg: don't use sym_table shared variable
......................................................................


Patch Set 2:

The commit message doesn't explain the rationale behind the change. Also, maybe use a capital letter after the final ":".


-- 
To view, visit https://review.coreboot.org/27810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a8da75498f871a53eb7509f6145c4842e3373
Gerrit-Change-Number: 27810
Gerrit-PatchSet: 2
Gerrit-Owner: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Paul Kocialkowski <contact at paulk.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 10 Aug 2018 09:24:51 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180810/8465d9dd/attachment.html>


More information about the coreboot-gerrit mailing list