[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku

[Nick Vaccaro (Code Review)]

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/27997


Change subject: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku
......................................................................

mb/google/poppy/variant/nocturne: update PL2 based on CPU sku

This patch adds a function to overwrite PL2 setting based on CPU
sku. From doc #594883, PL2 is 18W for AML-Y.

BUG=b:110890675
BRANCH=None
TEST=emerge-nocturne coreboot chromeos-bootimage & test with AML-Y
     and KBL-Y skus.

Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/Makefile.inc
A src/mainboard/google/poppy/variants/nocturne/mainboard.c
2 files changed, 46 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/27997/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
index b78b7a3..c17a49c 100644
--- a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
@@ -19,3 +19,4 @@
 
 ramstage-y += gpio.c
 ramstage-y += nhlt.c
+ramstage-y += mainboard.c
diff --git a/src/mainboard/google/poppy/variants/nocturne/mainboard.c b/src/mainboard/google/poppy/variants/nocturne/mainboard.c
new file mode 100644
index 0000000..07a4e66
--- /dev/null
+++ b/src/mainboard/google/poppy/variants/nocturne/mainboard.c
@@ -0,0 +1,45 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018 Google Inc.
+ * Copyright (C) 2018 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <baseboard/variants.h>
+#include <chip.h>
+#include <device/device.h>
+#include <device/pci_ids.h>
+#include <device/pci_ops.h>
+
+#define PL2_AML	18
+#define PL2_KBL	15
+
+static uint32_t get_pl2(void)
+{
+	uint16_t id;
+	id = pci_read_config16(SA_DEV_IGD, PCI_DEVICE_ID);
+	/* Assume we only have KLB-Y and AML-Y SKUs */
+	if (id == PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM)
+		return PL2_KBL;
+
+	return PL2_AML;
+}
+
+/* Override dev tree settings per board */
+void variant_devtree_update(void)
+{
+	struct device *root = SA_DEV_ROOT;
+	config_t *cfg = root->chip_info;
+
+	/* Update PL2 based on CPU */
+	cfg->tdp_pl2_override = get_pl2();
+}

-- 
To view, visit https://review.coreboot.org/27997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973
Gerrit-Change-Number: 27997
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/d55cadd7/attachment-0001.html>