[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Configure WiFi wake as NC when using CNVi

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu Aug 9 23:36:44 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27993


Change subject: mb/google/octopus: Configure WiFi wake as NC when using CNVi
......................................................................

mb/google/octopus: Configure WiFi wake as NC when using CNVi

When CNVi is being used, external wake using GPIO_119 is not
required. This change configures GPIO_119 as PAD_NC if CNVi is taken
out of reset.

BUG=b:112371978

Change-Id: Ifee90f428ed43c4d7c612c170476aff43b4a33ce
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/mainboard.c
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/27993/1

diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c
index 61baa33..61d254e 100644
--- a/src/mainboard/google/octopus/mainboard.c
+++ b/src/mainboard/google/octopus/mainboard.c
@@ -50,6 +50,15 @@
 	return false;
 }
 
+static void disable_wifi_wake(void)
+{
+	static const struct pad_config wifi_wake_gpio[] = {
+		PAD_NC(GPIO_119, UP_20K),
+	};
+
+	gpio_configure_pads(wifi_wake_gpio, ARRAY_SIZE(wifi_wake_gpio));
+}
+
 static void mainboard_init(void *chip_info)
 {
 	int boardid;
@@ -66,6 +75,9 @@
 	gpio_configure_pads_with_override(base_pads, base_num,
 			override_pads, override_num);
 
+	if (!is_cnvi_held_in_reset())
+		disable_wifi_wake();
+
 	mainboard_ec_init();
 }
 

-- 
To view, visit https://review.coreboot.org/27993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifee90f428ed43c4d7c612c170476aff43b4a33ce
Gerrit-Change-Number: 27993
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/a21e3f05/attachment-0001.html>


More information about the coreboot-gerrit mailing list