[coreboot-gerrit] Change in coreboot[master]: security/vboot: Split fwid.region build target

Maulik V Vaghela (Code Review) gerrit at coreboot.org
Thu Aug 9 13:25:35 CEST 2018


Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/27884 )

Change subject: security/vboot: Split fwid.region build target
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:

https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc@232
PS1, Line 232: file
> Oh, right, carry on then.
This function will only work for make version 4.2 and higher.For lower version it'll give an error. Can we capture this somewhere?



-- 
To view, visit https://review.coreboot.org/27884
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0
Gerrit-Change-Number: 27884
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/c2c1c7a7/attachment.html>


More information about the coreboot-gerrit mailing list