[coreboot-gerrit] Change in coreboot[master]: [TESTONLY]nb/intel/i945: Only disable VGA decode on IGD

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Aug 9 12:22:21 CEST 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27985


Change subject: [TESTONLY]nb/intel/i945: Only disable VGA decode on IGD
......................................................................

[TESTONLY]nb/intel/i945: Only disable VGA decode on IGD

Could be some targets don't have enough pci_mmio_size...

Change-Id: I4f1e1ab349b3e4bcb4d49da4b6d091e57243ee8f
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/i945/gma.c
1 file changed, 1 insertion(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27985/1

diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 83dc42e..2e6cebf 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -729,13 +729,7 @@
 	struct device *dev_host = dev_find_slot(0, PCI_DEVFN(0x0, 0));
 
 	pci_write_config16(dev, GCFC, 0xa00);
-	pci_write_config16(dev_host, GGC, (1 << 1));
-
-	unsigned int reg32 = pci_read_config32(dev_host, DEVEN);
-	reg32 &= ~(DEVEN_D2F0 | DEVEN_D2F1);
-	pci_write_config32(dev_host, DEVEN, reg32);
-
-	dev->enabled = 0;
+	pci_or_config16(dev, GGC, 1 << 1);
 }
 
 static void gma_func1_init(struct device *dev)

-- 
To view, visit https://review.coreboot.org/27985
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f1e1ab349b3e4bcb4d49da4b6d091e57243ee8f
Gerrit-Change-Number: 27985
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/87bb1200/attachment.html>


More information about the coreboot-gerrit mailing list