[coreboot-gerrit] Change in coreboot[master]: lib: Add blob_provider functionality
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Aug 9 03:21:06 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24992 )
Change subject: lib: Add blob_provider functionality
......................................................................
Patch Set 10:
(30 comments)
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h
File src/include/blob_provider.h:
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@32
PS10, Line 32: ID_ACPI_SLIC,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@33
PS10, Line 33: ID_ACPI_DSDT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@34
PS10, Line 34: ID_ACPI_SSDT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@35
PS10, Line 35: ID_MICROCODE,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@36
PS10, Line 36: ID_MICROCODE_RMU,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@37
PS10, Line 37: ID_MRC_CACHE,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@38
PS10, Line 38: ID_VGA_VBT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@39
PS10, Line 39: ID_NVRAM_CMOS_LAYOUT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@40
PS10, Line 40: ID_NVRAM_CMOS_DEFAULT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@41
PS10, Line 41: ID_NVRAM_VPD,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@42
PS10, Line 42: ID_SPD,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@43
PS10, Line 43: ID_MAC,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@44
PS10, Line 44: ID_AMD_S3NV,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@45
PS10, Line 45: ID_MRC_CACHE_RW_REGION,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@46
PS10, Line 46: ID_NVRAM_VPD_RO_REGION,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@47
PS10, Line 47: ID_AMD_AGESA,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@48
PS10, Line 48: ID_AMD_AGESA_PRE_MEM,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@49
PS10, Line 49: ID_AMD_AGESA_POST_MEM,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@50
PS10, Line 50: ID_AMD_PSP,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@51
PS10, Line 51: ID_INTEL_MRC,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@52
PS10, Line 52: ID_INTEL_FSP_S,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@53
PS10, Line 53: ID_INTEL_FSP_M,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@54
PS10, Line 54: ID_INTEL_MMA,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@55
PS10, Line 55: ID_NVIDIA_MTC,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@56
PS10, Line 56: ID_QUALCOMM_CDT,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@57
PS10, Line 57: ID_QUALCOMM_DDR,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@58
PS10, Line 58: ID_QUALCOMM_TZ,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/include/blob_provider.h@59
PS10, Line 59: ID_QUALCOMM_RPM,
please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/10/src/lib/blob_provider.c
File src/lib/blob_provider.c:
https://review.coreboot.org/#/c/24992/10/src/lib/blob_provider.c@71
PS10, Line 71: if (lookup_rdev(locator, &data) < 0) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/24992/10/src/lib/blob_provider.c@84
PS10, Line 84: if (lookup_rdev(locator, data) < 0) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/24992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abc5be5d47a4c697c0b94babb068b0f0ae4794
Gerrit-Change-Number: 24992
Gerrit-PatchSet: 10
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-CC: Youness Alaoui <snifikino at gmail.com>
Gerrit-Comment-Date: Thu, 09 Aug 2018 01:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/2d2beac2/attachment.html>
More information about the coreboot-gerrit
mailing list