[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP

Martin Roth (Code Review) gerrit at coreboot.org
Wed Aug 8 23:52:57 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/27930 )

Change subject: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP
......................................................................

mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP

This configures the ACPI FADT perferred power management profile to
PM_MOBILE instead of PM_DESKTOP.

I'm not sure what impact this actually has. I just noticed the other
boards have it set.

BUG=b:110971913
TEST=Made sure SYSTEM_TYPE_LAPTOP shows up in coreboot.config

Change-Id: Iea1b8359b80d167e69745358f543f025713294ba
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
Reviewed-on: https://review.coreboot.org/27930
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index 5565d57..fbd1fb0 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -43,6 +43,7 @@
 	select PCIEXP_COMMON_CLOCK
 	select PCIEXP_L1_SUB_STATE
 	select HAVE_EM100_SUPPORT
+	select SYSTEM_TYPE_LAPTOP
 
 if BOARD_GOOGLE_BASEBOARD_KAHLEE
 

-- 
To view, visit https://review.coreboot.org/27930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1b8359b80d167e69745358f543f025713294ba
Gerrit-Change-Number: 27930
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180808/f71e17db/attachment.html>


More information about the coreboot-gerrit mailing list