[coreboot-gerrit] Change in coreboot[master]: google/bobba: Add Raydium touch screen support

Pan Sheng-Liang (Code Review) gerrit at coreboot.org
Wed Aug 8 11:41:09 CEST 2018


Hello Sheng-Liang Pan,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/27954

to review the following change.


Change subject: google/bobba: Add Raydium touch screen support
......................................................................

google/bobba: Add Raydium touch screen support

Current coreboot does not create ACPI device for OS to recognize Raydium
touchscreen.

List the touch screen in the devicetree so that the correct ACPI device
are created.

BUG=b:none
BRANCH=master
TEST=emerge-octopus coreboot

Change-Id: Ic61a69e19e97520da0702dfe6cb7496563fc34f4
Signed-off-by: Pan Sheng-Liang <sheng-liang.pan at quanta.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/27954/1

diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
index 466d19b..a0972cc 100644
--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
@@ -43,6 +43,18 @@
 				register "has_power_resource" = "1"
 				device i2c 10 on end
 			end
+			chip drivers/i2c/generic
+				register "hid" = ""RAYD0001""
+				register "desc" = ""Raydium Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
+				register "reset_delay_ms" = "1"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
+				register "enable_delay_ms" = "50"
+				register "has_power_resource" = "1"
+				device i2c 39 on end
+			end
 		end	# - I2C 7
 	end
 end

-- 
To view, visit https://review.coreboot.org/27954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic61a69e19e97520da0702dfe6cb7496563fc34f4
Gerrit-Change-Number: 27954
Gerrit-PatchSet: 1
Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw at gmail.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan at quanta.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180808/089a3805/attachment.html>


More information about the coreboot-gerrit mailing list